Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump github.com/knadh/koanf to v2.0.1 #3308

Merged
merged 1 commit into from
Jun 10, 2023
Merged

chore(deps): bump github.com/knadh/koanf to v2.0.1 #3308

merged 1 commit into from
Jun 10, 2023

Conversation

kralicky
Copy link
Contributor

@kralicky kralicky commented Jun 7, 2023

Part of ory/x#693

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #3308 (43746bb) into master (b43c50c) will increase coverage by 0.06%.
The diff coverage is 81.25%.

❗ Current head 43746bb differs from pull request most recent head 8b547ac. Consider uploading reports for the commit 8b547ac to get more accurate results

@@            Coverage Diff             @@
##           master    #3308      +/-   ##
==========================================
+ Coverage   78.08%   78.14%   +0.06%     
==========================================
  Files         325      325              
  Lines       21054    21054              
==========================================
+ Hits        16439    16453      +14     
+ Misses       3388     3375      -13     
+ Partials     1227     1226       -1
Impacted Files Coverage Δ
hash/hash_comparator.go 85.56% <81.25%> (ø)

... and 3 files with indirect coverage changes

@kralicky kralicky marked this pull request as ready for review June 9, 2023 17:55
@kralicky kralicky requested review from aeneasr and zepatrik as code owners June 9, 2023 17:55
@aeneasr aeneasr merged commit 950b41a into ory:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kralicky @aeneasr